(substepping) reverse 0e0cc6d patch on the particle type sent to ptmass_accrete #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
As noted in #588. There was an issue on the type of particle sent to
ptmass_accretewhenntypes<=1. Only particles on the sameiphasevalue of the first particle in arrays were able to accrete. I proposed a patch 1 month ago to allow only active particles to enter in accretion loop which revealed to be a mistake. Inactive particles are meant to be awakened in the accretion loop if close enough to a sink particle. Then this feature is broken if only active particles are sent in this loop.The solution proposed in #588 is then the right one.
Testing:
One line fix to reverse a mistake... No testing needed
Did you run the bots? no
Did you update relevant documentation in the docs directory? no