Slow down method and few fixes on the new star formation prescription #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks ok to merge. Main question is, how would you know if this is broken in the code? What we really need here to keep this from being broken is an automated unit test, for example could we repeat some of the tests in Wang et al. (2020) as part of the test suite...? |
|
Yes, you right. I will work on it ! |
|
After a lot of fixes and fine tuning, the test should be almost ready. I checked manually the results and it's perfect. I'm finishing automatic checks and It should be good to go ! |
|
I think everything is fine now. The only failing seems to be a failed download... |
danieljprice
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new physics
Description:
Slow down method during subgroups integration. This method slows down the inner motion of weakly perturbed binaries in subgroups to relax constraints on the time step. It is still possible to follow secular evolution of this binaries without integrating their real fast motion. We loose the orbital phase but the computational gain is significant. See Mikkola and Aarseth (1996) and Wang et al. (2020) for more details.
Testing:
This new feature has been tested using the setup hierarchical reproducing tests done in Wang et al. (2020)...
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no