Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened the project in CLion IDE and it automatically created
build
directory executed the autoreconf command:The command upgraded Makefile.in file and I committed the change in 254d873
Also I added the
build
folder and all generated files to .gitignore.Debian has own patched version that you can see in https://salsa.debian.org/lhw-guest/network-manager-ssh
When you release a new version your changes are merged https://salsa.debian.org/lhw-guest/network-manager-ssh/-/commit/0c5c71d60abbf56ce8588dbb529ea38b9b66b990
So it would be nice to grab those changes into the upstream code to minimize burden of maintaining.
Some changes in debian folder are safe to copy what I did in the c414baf
The Debian package also has a patch that renames the appdata folder to metainfo. This is more standard
https://wiki.debian.org/AppStream/Guidelines
So I applied the patch too.
The
debian
folder needs for some changes too but that needs to be changed and tested separately:The
debian/sources/format
should be changed to3.0 (native)
because this is an original package. Thedebian/patches
must be removed too.The
debian/compat
uses version 8 which is ancient and must be updated to at least 11.The
debian/rules
is over-complicated: it clones sources (of itself) from git. Instead ideally it should be just:And everything else will be made by the
debuild
itself.@lhw you are a Debian maintainer so can you please send a PR to make the upstream to be debianized out of the box?