Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LINC API as a supported instance type for DANDI CLI #1527

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

aaronkanzer
Copy link
Member

@aaronkanzer aaronkanzer commented Nov 15, 2024

Relates to #1517
Follow-up of #1519 -- used a different fork since tags were not copied over in the prior fork in #1519

Cc @kabilar

Steps to properly test:

  1. pip uninstall dandi -y to remove DANDI CLI locally (can use a venv too if desired)
  2. pip install -e git+https://github.com/lincbrain/dandi-cli.git@ak-linc#egg=dandi -- reference my forked branch here as the dandi CLI version
  3. Made a Dandiset on LINC: https://lincbrain.org/dandiset/000045
  4. Run dandi download https://lincbrain.org/dandiset/000045/draft -- the CLI should prompt for an API value here
  5. I copied over an NWB into the 000045 folder
  6. Run dandi upload -i linc
  7. Observe files present in https://lincbrain.org/dandiset/000045/draft/files?location=

Prior to running any steps, I ran dandi instances to see that the proper values were listed

@jwodder @yarikoptic -- mind a brief re-review here?

I think we should be fine here -- it seems that sometimes the CI tests for Ubuntu can be flaky -- you'd know better than I if this is a common issue over time -- I know sometimes GitHub runners can be unpredictable with longer, parallel jobs

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (5066cca) to head (284ead1).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
- Coverage   88.57%   87.65%   -0.92%     
==========================================
  Files          78       78              
  Lines       10589    10591       +2     
==========================================
- Hits         9379     9284      -95     
- Misses       1210     1307      +97     
Flag Coverage Δ
unittests 87.65% <100.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronkanzer aaronkanzer marked this pull request as ready for review November 15, 2024 16:58
Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aaronkanzer. This looks good to me. I tested these changes using your instructions with https://lincbrain.org/dandiset/000044/draft. I can verify that I was only able to download and upload when using the correct lincbrain.org API key.

Let's go ahead and include updates to the docs in this pull request. See notes here: #1517 (comment).

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately we have some "manually" curated dumps of --help for commands and thus need to extend with this new instances the docs/source/cmdline/instances.rst file. Please add listing there too

@aaronkanzer
Copy link
Member Author

unfortunately we have some "manually" curated dumps of --help for commands and thus need to extend with this new instances the docs/source/cmdline/instances.rst file. Please add listing there too

Updated!

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Nov 15, 2024
@yarikoptic yarikoptic merged commit 06c10cc into dandi:master Nov 15, 2024
21 of 23 checks passed
@aaronkanzer
Copy link
Member Author

@yarikoptic @jwodder -- did this not get fully released to PyPI? Just noticing that there is no new patch version at https://pypi.org/project/dandi/#history

@jwodder
Copy link
Member

jwodder commented Nov 15, 2024

@aaronkanzer The PR didn't have the "release" label, so no release was triggered.

@aaronkanzer
Copy link
Member Author

@jwodder -- would the preferred route to release then be that I push a trivial change with those labels then?

@yarikoptic
Copy link
Member

merged

with release... release should come shortly

Copy link

🚀 PR was released in 0.64.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants