Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one insignificant typo in CHANGELOG #1477

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix one insignificant typo in CHANGELOG #1477

merged 1 commit into from
Aug 8, 2024

Conversation

yarikoptic
Copy link
Member

Mostly to cut a release

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w CHANGELOG.md",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic added documentation Changes only affect the documentation release Create a release when this pr is merged labels Aug 8, 2024
@yarikoptic yarikoptic changed the title [DATALAD RUNCMD] Fix one insignificant typo in CHANGELOG Fix one insignificant typo in CHANGELOG Aug 8, 2024
@@ -43,7 +43,7 @@

- Rewind filehandle request bodies before retrying requests [#1444](https://github.com/dandi/dandi-cli/pull/1444) ([@jwodder](https://github.com/jwodder))
- Slight tune up to formatting of examples etc to harmonize appearance/make shorter [#1439](https://github.com/dandi/dandi-cli/pull/1439) ([@yarikoptic](https://github.com/yarikoptic))
- Fix spelling of netlify and insstance [#1433](https://github.com/dandi/dandi-cli/pull/1433) ([@rly](https://github.com/rly) [@yarikoptic](https://github.com/yarikoptic))
- Fix spelling of netlify and instance [#1433](https://github.com/dandi/dandi-cli/pull/1433) ([@rly](https://github.com/rly) [@yarikoptic](https://github.com/yarikoptic))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since netlify is in fixed form, makes sense to have instance also in a fixed form ;)

@yarikoptic
Copy link
Member Author

I do not expect effect on CIs - so will merge to release

@yarikoptic yarikoptic merged commit 570f617 into master Aug 8, 2024
25 checks passed
@yarikoptic yarikoptic deleted the bf-typo branch August 8, 2024 02:54
Copy link

github-actions bot commented Aug 8, 2024

🚀 PR was released in 0.63.0 🚀

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (9ae6128) to head (54c9e52).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   88.52%   88.60%   +0.08%     
==========================================
  Files          77       77              
  Lines       10560    10560              
==========================================
+ Hits         9348     9357       +9     
+ Misses       1212     1203       -9     
Flag Coverage Δ
unittests 88.60% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant