Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non supported vast error #481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZacharieTFR
Copy link
Contributor

Description

  • vast client will now trigger error code 102 VAST version of response not supported. if it parse a outdated VAST version (only 1.0 for now)
  • Fix error 303 No VAST response after one or more Wrappers not being triggered when a wrapper containing a <Creative> without mediafile (e.g only with a <CompanionAds> inside) does not result in a VAST response.

Issue

#476

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@ZacharieTFR ZacharieTFR self-assigned this Nov 12, 2024
Copy link
Contributor

@clarissedmn clarissedmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@@ -7,6 +7,8 @@ Whenever an error occurs during the VAST parsing, the parser will call on his ow

* VAST error `101`: VAST schema validation error.

* VAST error `102`: VAST version of response not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* VAST error `102`: VAST version of response not supported.
* VAST error `102`: VAST response version not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants