fix bug where fallback was not working if first ad element return empty #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-si
reviewed
Feb 28, 2024
| @@ -458,7 +458,7 @@ export class VASTParser extends EventEmitter { | |||
| return Promise.all(resolveWrappersPromises).then((unwrappedAds) => { | |||
| const resolvedAds = util.flatten(unwrappedAds); | |||
|
|
|||
| if (!resolvedAds && this.remainingAds.length > 0) { | |||
There was a problem hiding this comment.
looks good to me
!0 = true
!(non zero length) = false
ZacharieTFR
approved these changes
Mar 21, 2024
|
@ZacharieTFR @Rapha0511 when we are planning to release this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/dailymotion/vast-client-js/blob/master/src/parser/vast_parser.js#L461C25-L461C25
The condition will never be reach since
!resolvedAdswill always befalse.So in case the first Ad element of a VAST is empty or it fails, it will never fallback to the next Ad element.
Issue
If any Ad element (going from top to bottom) fails to fetch xml or return empty vast, it will not fallback to next Ad Element.
Issue Link
Type