Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: edit source post moderation entity #3796

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat: edit source post moderation entity #3796

merged 5 commits into from
Nov 14, 2024

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Nov 14, 2024 •
edited by github-actions bot
Loading

Changes

  • Make the edit page be reusable to post moderation request.
  • At first I thought of writing a whole edit page solely for the post moderation, but realized that it would be just the same and whole lot of copy-pasting. Would love to hear some thoughts if anyone thinks a dedicated page is a good option. Keep in mind that the internal components updated here would still have the same changes.
  • Also updated the types and graphql schemas to better reflect our standard when it comes to related entities.
  • I've tested both freeform and sharing internal posts.

TODO:

  • Test external link process flow.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-622 #done

Preview domain

https://mi-622.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner November 14, 2024 08:05
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Nov 14, 2024 7:19pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Nov 14, 2024 7:19pm

@ilasw ilasw mentioned this pull request Nov 14, 2024
Open
@sshanzel sshanzel requested a review from ilasw November 14, 2024 11:57
ilasw
ilasw approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@ilasw ilasw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Love reusing the same page.

Maybe we can pass a query string to make the form understand if moderation entity or classic post, just to prevent the double query.

Just make sure to rename the loading variables for better maintainability.

Overal 💯

packages/shared/src/components/post/write/ShareLink.tsx Outdated
@@ -51,19 +68,34 @@ export function ShareLink({
const onSubmit: FormEventHandler<HTMLFormElement> = (e) => {
e.preventDefault();

if (isPosting || isLoading) {
if (isPosting || isPending || isLoading) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is better to rename isPending and isLoading for give some context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, let me update these ones.

@sshanzel
Copy link
Member Author

Maybe we can pass a query string to make the form understand if moderation entity or classic post, just to prevent the double query.

Yeah, that's a good point, we can do that 👀

@sshanzel sshanzel merged commit 219e654 into MI-521 Nov 14, 2024
9 checks passed
@sshanzel sshanzel deleted the MI-622 branch November 14, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilasw ilasw ilasw approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @ilasw