-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added possibility to clear profile & cover photos #3734
base: main
Are you sure you want to change the base?
Conversation
@n-d-r-d-g is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! I think there is also one thing we should update, the part where we early return if the passed value is null here:
@sshanzel Makes sense. I understand that the early return needs to be removed. Is that right? Btw, I've added a background on the profile picture to fix an issue I found: |
@n-d-r-d-g hey. Overall it looks amazing. As you and I can tell, there seems to be an issue with the gql request not updating the images after refresh. I will discuss this internally, as there is one thing to check within the API side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the addition
Fixes dailydotdev/daily#1534.
Changes
I've added a 'X' button at the top right corner of the profile and cover images at /account/profile to enable the user to clear the image.
Please note that I have not been able to test this functionality completely on Gitpod due to an unexpected error when uploading the cover image. The images are cleared on the web app. Not sure if the API call is working fine.