feat(history-sync): add encode interface
#535
Open
+61
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a105c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
XiNiHa
commented
Nov 15, 2024
| articleId: String(id), | ||
| }), | ||
| decode: ({ articleId }) => ({ | ||
| id: Number(articleId), |
There was a problem hiding this comment.
I'm pretty surprised that the decode function can be used to make non-string activity params, which clashes with the assumption of ActivityBaseParams that expects Record<string, string | unknown>. Is it okay?
XiNiHa
force-pushed
the
history-codec
branch
from
8eb426c
to
0a105c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodeinterface, counterpart of the existingdecodeinterfaceencodeanddecodewith Future API