Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace and fix edge example #489

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The Edge example in src/examples/edge.yml fails with the message:

Can't run because you've entered an invalid browser name.

Browser: edge was not found on your system or is not supported by Cypress.

Change

Replace the usage section in src/examples/edge.yml with the following workflow code:

version: 2.1
orbs:
  cypress: cypress-io/cypress@3
executors:
  cypress-browsers:
    docker:
      - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1
jobs:
  edge-test:
    executor: cypress-browsers
    steps:
      - cypress/install
      - cypress/run-tests:
          start-command: "npm run start:dev"
          cypress-command: 'npx cypress run --browser edge'
workflows:
  use-my-orb:
    jobs:
      - edge-test
  • Use the commands

    instead of the job

    • cypress/run which is restricted to Electron, Chrome and Firefox
  • Update the Cypress Docker image to
    cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399
Copy link
Collaborator Author

Tested successfully separately:

image

@jennifer-shehane jennifer-shehane merged commit fab347f into cypress-io:master Oct 1, 2024
9 of 10 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/edge-example branch October 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge example fails - source code
3 participants