Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pnpm #445

Closed
wants to merge 3 commits into from

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Dec 6, 2023

This adds support for pnpm as a package manager.

Closes #442

This is currently blocked by CircleCI-Public/node-orb#199

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

jobs:
- cypress/run:
package-manager: "pnpm"
start-command: "pnpm start"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the install-command argument to this example as well: pnpm install --frozen-lockfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added now

Copy link
Contributor

@jordanpowell88 jordanpowell88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution @ramykl

@jordanpowell88 jordanpowell88 changed the title adding support for pnpm feat: adding support for pnpm Jan 11, 2024
@jordanpowell88 jordanpowell88 changed the title feat: adding support for pnpm minor: adding support for pnpm Jan 11, 2024
@jordanpowell88 jordanpowell88 changed the title minor: adding support for pnpm minor: add support for pnpm Jan 11, 2024
@jordanpowell88 jordanpowell88 changed the title minor: add support for pnpm feat: add support for pnpm Jan 11, 2024
@jordanpowell88
Copy link
Contributor

Closing in favor of #452

@ramykl
Copy link
Contributor Author

ramykl commented Jan 11, 2024

@jordanpowell88 Thanks for taking this on. Do you know anyone that could get this PR against the circleci node-orb as it would help improve this repo too?

@ramykl ramykl deleted the add-support-for-pnpm branch February 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package manager:PNPM not supported in circleci orb
4 participants