-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pnpm #445
Conversation
|
130d069
to
fe3dc80
Compare
jobs: | ||
- cypress/run: | ||
package-manager: "pnpm" | ||
start-command: "pnpm start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the install-command
argument to this example as well: pnpm install --frozen-lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the contribution @ramykl
Closing in favor of #452 |
@jordanpowell88 Thanks for taking this on. Do you know anyone that could get this PR against the circleci node-orb as it would help improve this repo too? |
This adds support for pnpm as a package manager.
Closes #442
This is currently blocked by CircleCI-Public/node-orb#199