Skip to content

Commit

Permalink
NEWS and CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Oct 10, 2023
1 parent 2aa59f8 commit d5d090f
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 91 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Suggests:
pool,
progress,
reactable,
RMariaDB (>= 1.2.2.9008),
RMariaDB (>= 1.3.0),
rmarkdown,
RPostgres,
RSQLite (>= 2.2.8),
Expand Down
122 changes: 37 additions & 85 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,127 +4,79 @@

## Breaking changes

- Breaking change: Add `check_dots_empty()` calls (#1929, #1943).
- Breaking change: Add `check_dots_empty()` calls to methods (#1929, #1943).

## Bug fixes

- Snapshot test.
- Stable sort order in test.
- Remove unwanted changes.
- Compatibility with duckdb 0.9.0.

- Minor fixes in `dm_pack_tbl()` and `dm_unwrap_tbl()` (#1947).

## Features

- `copy_dm_to()` now warns unconditionally on unsupported arguments, and fails if `copy_to` is provided. Use the new `dm_sql()` function as a replacement for `copy_dm_to(copy_to = )`.
- Reuse existing `build_copy_queries()` code for `dm_sql()` (#2011).
- `dm_sql()` returns nested named lists.
- `copy_dm_to()` now warns unconditionally on unsupported arguments, and fails if `copy_to` is provided. Use the new `dm_sql()` function (#1915, #2011, @jangorecki) as a replacement for `copy_dm_to(copy_to = )` (#1944).

- New `json_unnest()` and `json_unpack()`, currently implemented for data frames only (#991, #997).

- `dm_rows_append()` also works for local dm, with support for autoincrement primary keys (#1727, #1745).
- Add `dm_sql()` and friends, still need tests (#1915).

- Breaking change: Add `check_dots_empty()` calls (#1929, #1943).

- Test MySQL on GHA (#1940).

- Improve MySQL compatibility regarding learning of database schemas and checking of constraints (#1938).

## Chore
## Documentation

- Update docker/build-push-action digest to 0f84726.

- Move deprecated argument.

- Stabilize and improve tests (#2031).
- Remove DBI import (#1974).
- Add technical helper to `.Rbuildignore`.
- Simplify `merge_group` in GHA.
- Stabilize tests, add snapshot tests for `dm_sql()` for all databases (#1987).
- Enable merge queue.
- Indicate MySQL server, bump to dev version of RMariaDB, work around tidyverse/dbplyr#1190 (#1989).
- Snapshots (#1985).
- Remove magrittr import (#1975).
- Prepare for removal of magrittr imports (#1983).
- Add FIXME.
- Support loading with empty NAMESPACE file.
- Move pillar to Suggests (#1976).
- Switch to usethis imports, blanket vctrs import.
- Switch internal testing to MariaDB.
- Explain reasoning behind SQLite.
- Parallel.
- Update dependency ubuntu to v22 (#1969).
- Update dependency font-awesome to v6.4.2 (#1965).
- Update actions/checkout action to v4 (#1966).
- Update dessant/lock-threads action to v4 (#1967).
- Update peter-evans/create-pull-request action to v5 (#1968).
- Update docker/login-action digest to b4bedf8 (#1960).
- Update docker/metadata-action digest to 879dcbb (#1962).
- Update docker/setup-buildx-action digest to dedd61c (#1963).
- Update docker/build-push-action digest to 4c1b68d.
- Recategorize and describe function reference.

- Stabilize test.
- Better error and information messages when querying keys.

- Indent.
- `collect.zoomed_dm()` shows a more helpful error message (#1929, #1945).

- Use `table_names_out` as source of truth for remote table names.
- Add information on default font size to `?dm_draw` (#1935).

- Explicit parallelization.
- Add `db-*` rules to Makefile to simplify Docker-based database setup.

- Reformat.
## Performance

- Prefer `map*()` over `lapply()` and `vapply()`.
- Replace `tibble()` by `fast_tibble()` (@mgirlich, #1928).

- `styler::style_pkg(scope = "tokens")`.
- Replace superseded `dplyr::recode()` (@mgirlich, #1927).

- Better error and information messages when querying keys.
## Testing

- Explicit qualification.
- Add explicit unique key to `dm_for_filter()`.

- Fast offline checks with environment variable.
- Add Postgres test for `dm_sql()`.

- Prioritize learning test.
- Switch internal testing to MariaDB.

- Fast offline checks with new `"DM_OFFLINE"` environment variable.

- Add skips to `test_src_*()` calls.
- Throw away GHA cache.
- Remove dead code (#979, #1950).
- Rename internal `new_dm3()` to `dm_from_def()` (#1225, #1949).
- New GHA checks for the case of missing suggested packages (#1952).
- Carefully check if suggested packages are installed.
- Avoid `dbplyr::ident_q()` (#1788).
Closes #1788.
- Remove dead code (#1871).
Closes #1871.
- Fix typo, dm_unwrapped_tbl -\> dm_unwrapped.
- New targets, for silent testing.
- Enhance test snapshot from last change.
- Stabilize tests.
- New `ltest` and `.NOTPARALLEL` targets.
- Reorganize `build_copy_queries()` (#1923).
- Add ellipsis to `tbl_sum()` signature (#1941).
- Fix test compatibility.
- Don't cache with scheduled builds.

## Documentation
## Chore

- Add db-\* rules to Makefile.
- Tweaks.
- Recategorize and describe function reference.
- `collect.zoomed_dm()` shows a more helpful error message (#1929, #1945).
- Deprecate `copy_dm_to(copy_to = )` argument (#1944).
- Add information on default font size to `?dm_draw` (#1935).
- Move magrittr (#1975, #1983), DBI (#1974), and pillar (#1976) to `"Suggests"`.

## Performance
- Require RMariaDB 1.3.0, work around tidyverse/dbplyr#1190 and tidyverse/dbplyr#1195 (#1989).

- Replace `tibble()` by `fast_tibble()` (@mgirlich, #1928).
- Replace superseded `dplyr::recode()` (@mgirlich, #1927).
## Internal

## Testing
- Prefer `map*()` over `lapply()` and `vapply()`.

- Add explicit unique key to `dm_for_filter()`.
- Add Postgres test for `dm_sql()`.
- `styler::style_pkg(scope = "tokens")`.

- Rename internal `new_dm3()` to `dm_from_def()` (#1225, #1949).

- Remove dead code (#979, #1950, #1871).

- Reorganize `build_copy_queries()` (#1923).

## Uncategorized
- Avoid `dbplyr::ident_q()` (#1788).

- Merge pull request #1954 from cynkra/renovate/configure.
- Merge pull request #1942 from cynkra/f-error-msg.
- Merge branch 'cran-1.0.6'.
- Add ellipsis to `tbl_sum()` signature (#1941).


# dm 1.0.6
Expand Down
8 changes: 3 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
dm 1.0.6.9011
dm 1.0.7

## Cran Repository Policy

Expand All @@ -7,10 +7,8 @@ dm 1.0.6.9011
## R CMD check results

- [x] Checked locally, R 4.3.1
- [ ] Checked on CI system, R 4.3.1
- [ ] Checked on win-builder, R devel

Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.
- [x] Checked on CI system, R 4.3.1
- [x] Checked on win-builder, R devel

## Current CRAN check results

Expand Down

0 comments on commit d5d090f

Please sign in to comment.