Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

173 cash flows #174

Merged
merged 4 commits into from
Sep 5, 2023
Merged

173 cash flows #174

merged 4 commits into from
Sep 5, 2023

Conversation

kasperjo
Copy link
Collaborator

@kasperjo kasperjo commented Sep 5, 2023

Added a cash_flow function and a test. (I ended up needing this for the stat arb project.) Let me know if it makes sense.

Also, the pre-commit tests are now passing.

@kasperjo kasperjo linked an issue Sep 5, 2023 that may be closed by this pull request
@kasperjo kasperjo requested a review from tschm September 5, 2023 18:20
@tschm
Copy link
Collaborator

tschm commented Sep 5, 2023

@kasperjo: I would just call it cashflow and not cash_flows

Copy link
Collaborator

@tschm tschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like

@kasperjo
Copy link
Collaborator Author

kasperjo commented Sep 5, 2023

@tschm I'm not allowed to merge due to "The base branch does not allow update". What does this mean?

@kasperjo kasperjo merged commit 519448d into main Sep 5, 2023
13 checks passed
@tschm tschm deleted the 173-cash-flows branch September 5, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cash flows
2 participants