Right click layerlist layer

[alukach]

In response to the comments on #205, here's a first-shot at adding right-click menu support for layers on the layerlist.

This entailed a bit of a refactor in the way menus currently worked. Each menu (left sidebar, operations menu, and right-click context-menu) was separated out into separate files and namespaces (dc.menus.left, dc.menus.geo, and dc.menus.layerContextMenu). A 'layerlist:added' signal was created to return newly added layers.

Currently, the right-click context menus only work on a single layer.

There's still work to be done:

• Add support for right-click operations on multiple selected layers.
• Limit context-menu options based on layers selected (eg 'rename' would only apply to single layer selections but 'zoom to extent' could take many layers).
• Write tests
• Remove redundant operations from left sidebar (likely everything under 'Geo Actions').
• Remove icons from layerlist layer item (the 'duplicate' operation should be moved to the right-click menu, the 'remove layer' operation should be removed). Should this be done?
• Add 'right-click' tip to "Welcome to dropchop!" text

I'm opening this up to get feedback. Is this the right direction for DropChop?

[alukach]

This was written before I saw how #208 rewrote how functions were loaded with the Left Sidebar Menu. This could probably be refactored to more closely match that style for the sake of simplicity. One win that this style has is that it could allow operations to be pulled from different files.

[alukach]

Supporting multiple layers turned out to be easier than I expected.

[mapsam]

Wowowow this is great! I'm very much into the idea of splitting menus into their own file, since they are growing larger. This makes a lot more sense (i.e. feels more droppychoppy) as well - the left-hand "geo actions" felt a bit forced, and very unintuitive since it all related to the layers you had selected anyways. 👍 for pushing this 😃

[alukach]

@mapsam great, glad you're into it. Feel free to add some styling changes/suggestions to the menu.

Got validation on the context-menu operations completed:

[alukach]

Update on this:

• Removed icons on side of layers, add an ellipses to indicate "more options". Left-clicking on ellipses button triggers right-click event (for touch-screen users)
• Added headers to the context-menu to allow the operations to be organized. Not sure about this feature, thoughts?
• problem: Currently, it's possible for a context menu to go offscreen. This can occur when right-clicking on layers near the bottom of the layerlist. Not sure what to do about this, adding a scrollbar (and autosizing the context menu) seems difficult.

[mapsam]

This is looking really great.

I think the overflow issue can be solved by doing a little bit of math - checking the height of the menu and the window and ensuring it never generates beyond it. I'd be happy to work on this part sometime this week!

[alukach]

@mapsam feel free to take a crack on keeping the menu on the screen. I admit that I hadn't really thought about just comparing the div size and placement to the window size and to ensure that it stays on screen, that sounds like a solid solution.

[mapsam]

I'll take a look - I'm in my last week out in Richmond for Code for America so might not get to it this week - feel free to try and merge in and I can take a crack in a separate branch!

[alukach]

Some style changes. Just to add some tests now...

[mapsam]

Added the portion to calculate the menu location based on the window size. Seems to be working nicely. I'm a big fan of this menu system, it's much improved @alukach!

Not sure why my version is missing those style changes, but hopefully it didn't bork anything!

[mapsam]

@alukach whenever you think this is ready to roll, feel free to merge!