hugo: Fix header not being hidden when scrolling to anchor. #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cue ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jpluscplusm
approved these changes
Nov 1, 2024
|
@JorindeUsMedia This issue, mentioned in the commit message, seems somewhat tangential. Are you sure that's the right issue, and not cue-lang/cue#3058?
|
- Fix js error on the tabs-nav widget which caused the javascript to fail when only 1 tab was present (console error about undefined tabslist) - Fix check on scrolldown: when scroll Y old is equal to scroll y new it should not assume it's scrolling up again. If a scroll-to-anchor was triggered twice (what happened here for some reason) it wrongly set scrolLDown to false while the old-Y & new-Y position were the same. To test: Go to /docs/concept/modules-packages-instances/#instances You should scroll down to the anchor and the header should be hidden. Closes cue-lang/cue#3058 Signed-off-by: Jorinde Reijnierse <[email protected]>
JorindeUsMedia
force-pushed
the
feature/3058
branch
from
2455e6d
to
c74afd3
Compare
@jpluscplusm ah you're right.. mixed up the issues by updating the commits/prs. Updated the commit message |
|
Imported as https://cuelang.org/cl/1203463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a scroll-to-anchor was triggered twice (what happened here for some
reason) it wrongly set scrolLDown to false while the old-Y & new-Y position
were the same.
To test:
Go to /docs/concept/modules-packages-instances/#instances You should scroll down to the anchor and the header should be hidden.
Closes cue-lang/cue#3058