Implementing a button for Presence in the 2de kamer #449
Conversation
lodewiges
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #449 +/- ##
========================================
Coverage 99.92% 99.92%
========================================
Files 203 207 +4
Lines 2708 2733 +25
========================================
+ Hits 2706 2731 +25
Misses 2 2 ☔ View full report in Codecov by Sentry. |
| 'before being removed from sofia your credits needs to be zero. | ||
| Please ask the board to be removed from sofia.') |
| @@ -101,6 +103,7 @@ def create_permissions(permission_map) | |||
| 'article' => %i[read], | |||
| 'article_comment' => %i[create read], | |||
| 'board_room_presence' => %i[read], | |||
| 'study_room_presence' => %i[read], | |||
There was a problem hiding this comment.
not so sure about this one. why do old members need to know this?
There was a problem hiding this comment.
it is the same type of information as board room presence, and oudleden are able to view that so that is why i made this choice, however, I do agree and this is not strictly needed.
There was a problem hiding this comment.
removing the permission for oudleden to view both would be the most logical thing. in my opinion. How do you think about it?
|
One more remark: all this backend stuff is veryveryvery similar to board room presence, but that does not imply that we should 'fix' anything about that: this is perfectly fine as is, because it's easy to maintain |
Yes, this is correct. I used the board room presence feature as the starting point. We will not be adding a component similar to this in the future(I think). Besides this leden and bestuur have different permissions for both buttons so I was unsure how to implement it without making it 2 separated components. and maybe in the future you could add a link to the scheduling document in the drop down or integrate it with our own planning tool. |
needed for csvalpha/amber-ui#891