[pset4] [recover] Add hashes for jpeg files without trailing zeros #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote Recover from pset4 in such a way that it would actually parse the jpeg headers and look for EOI (
FF D9
), and stop there. This means that my implementation doesn't save the trailing zeros after EOI -- only to realize that thecheck50
checks failed with 'recovered image does not match', even though the actual content in the JPEG was the same. I then went to the checks and realized that it was using hashes of JPEG files with the trailing zeros. I then wrote a new Recover in such a way that it preserved the trailing zeros, and the checks passed.The modifications in this PR add the hashes of the JPEG files without trailing zeros, while preserving the hashes of the JPEG files with the zeros.