Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing this up to Crystal 1.9.2 compatibility: #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bringing this up to Crystal 1.9.2 compatibility: #10

wants to merge 4 commits into from

Conversation

akitaonrails
Copy link

  • adding types for all methods and arguments
  • adding 'fetch(key, &block)' feature
  • adding expires_in default option to all stores that support it
  • implementing expires support for the MemoryStore
  • making all specs pass
  • updating benchmark to pass

@akitaonrails
Bringing this up to Crystal 1.9.2 compatibility:
7c5e17e 
- adding types for all methods and arguments
- adding 'fetch(key, &block)' feature
- adding expires_in default option to all stores that support it
- implementing expires support for the MemoryStore
- making all specs pass
- updating benchmark to pass
@akitaonrails
forgot to update shards and add support for Redis::PooledClient as well
c8cba39
@akitaonrails
fixing small bug in the new #fetch method
96c2b03
@akitaonrails
I may have found a strange type bug in Crystal. In the old way, somet…
ea16245 
…imes it errors out as 'value has no type' and trying to force with '.as(String)' crashes the compiler. But rearranging like this make it work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akitaonrails