Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: different maxGasWanted config leads hash mismatch #560

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 12, 2024

this bug was introduced in 773438f

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang November 12, 2024 10:01
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.21%. Comparing base (c9e06fa) to head (c49ae48).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/ante/eth.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #560   +/-   ##
========================================
  Coverage    46.21%   46.21%           
========================================
  Files          181      181           
  Lines        18132    18132           
========================================
  Hits          8380     8380           
  Misses        9036     9036           
  Partials       716      716           
Files with missing lines Coverage Δ
app/ante/eth.go 81.56% <0.00%> (ø)

@mmsqe mmsqe enabled auto-merge (squash) November 12, 2024 10:45
@mmsqe mmsqe merged commit 64bd2de into crypto-org-chain:develop Nov 12, 2024
37 of 39 checks passed
yihuang pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants