Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: check-tx don't run in parallel #552

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 1, 2024

Solution:

  • try with experimental flag

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- try with experimental flag
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (e52a555) to head (db69110).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
server/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #552   +/-   ##
========================================
  Coverage    46.17%   46.17%           
========================================
  Files          181      181           
  Lines        18124    18124           
========================================
  Hits          8368     8368           
  Misses        9039     9039           
  Partials       717      717           
Files with missing lines Coverage Δ
server/start.go 18.89% <0.00%> (ø)

@yihuang yihuang requested a review from mmsqe November 1, 2024 11:28
@yihuang yihuang marked this pull request as ready for review November 1, 2024 11:29
@mmsqe mmsqe enabled auto-merge (squash) November 1, 2024 13:25
@mmsqe mmsqe merged commit e4d00df into crypto-org-chain:develop Nov 1, 2024
36 of 38 checks passed
@yihuang yihuang deleted the parallel-check-tx branch November 2, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants