Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: rpc stream overhead even if not used #551

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 1, 2024

Solution:

  • init the underlying subscriptions lazily.

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- init the underlying subscriptions lazily.
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe November 1, 2024 04:10
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (885530b) to head (7e3a2b7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
rpc/stream/rpc.go 0.00% 22 Missing ⚠️
server/json_rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    46.16%   46.17%           
========================================
  Files          181      181           
  Lines        18125    18124    -1     
========================================
  Hits          8368     8368           
+ Misses        9040     9039    -1     
  Partials       717      717           
Files with missing lines Coverage Δ
server/json_rpc.go 0.00% <0.00%> (ø)
rpc/stream/rpc.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need skip PendingTxListener as well?

@yihuang
Copy link
Collaborator Author

yihuang commented Nov 1, 2024

do we need skip PendingTxListener as well?

good catch, let's ignore pending tx listener here, it's feed by check-tx ante handler, which don't block state machine.

the overhead of the other subscriptions are in the block commit flow.

@yihuang yihuang enabled auto-merge (squash) November 1, 2024 05:17
@yihuang yihuang merged commit 8afdc69 into crypto-org-chain:develop Nov 1, 2024
37 of 39 checks passed
@yihuang yihuang deleted the develop branch November 1, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants