Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: trace response for failed tx is not aligned with go-ethereum #441

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 27, 2024

align for more errors, https://github.com/ethereum/go-ethereum/blob/release/1.12/core/vm/errors.go#L24

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang March 27, 2024 10:52
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.56%. Comparing base (a53a373) to head (e5c93c4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #441   +/-   ##
========================================
  Coverage    62.56%   62.56%           
========================================
  Files          130      130           
  Lines        12512    12512           
========================================
  Hits          7828     7828           
  Misses        4138     4138           
  Partials       546      546           
Files Coverage Δ
x/evm/keeper/grpc_query.go 77.48% <0.00%> (ø)

@mmsqe mmsqe merged commit 213ddbc into crypto-org-chain:develop Mar 28, 2024
35 of 39 checks passed
yihuang pushed a commit that referenced this pull request Mar 29, 2024
…#441) (#442)

* Problem: trace response for failed tx is not aligned with go-ethereum

align for more errors, https://github.com/ethereum/go-ethereum/blob/release/1.12/core/vm/errors.go#L24

* cleanup

* diff group
@yihuang yihuang deleted the fix_trace branch March 29, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants