Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: not make use of sim utils from sdk #1117

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 28, 2023

For more info

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1117 (ba68894) into main (79c2758) will increase coverage by 24.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1117       +/-   ##
===========================================
+ Coverage   22.92%   47.08%   +24.16%     
===========================================
  Files          47       82       +35     
  Lines        3089     7312     +4223     
===========================================
+ Hits          708     3443     +2735     
- Misses       2311     3503     +1192     
- Partials       70      366      +296     
Files Changed Coverage Δ
app/state.go 0.00% <0.00%> (ø)

... and 50 files with indirect coverage changes

@mmsqe
Copy link
Collaborator Author

mmsqe commented Jul 29, 2023

/runsim

@github-actions
Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

@github-actions
Copy link

/runsim simulation test has failed 😅
Please further check here

@mmsqe
Copy link
Collaborator Author

mmsqe commented Jul 29, 2023

/runsim

@github-actions
Copy link

Simulation tests get triggered and started by /runsim.
Please check further progress here

@github-actions
Copy link

/runsim simulation test has succeeded 🎉
Please further check here

@mmsqe mmsqe marked this pull request as ready for review July 31, 2023 01:32
@mmsqe mmsqe requested a review from a team as a code owner July 31, 2023 01:32
@mmsqe mmsqe requested review from leejw51crypto and thomas-nguy and removed request for a team July 31, 2023 01:32
@mmsqe
Copy link
Collaborator Author

mmsqe commented Aug 2, 2023

/runsim

@crypto-org-chain crypto-org-chain deleted a comment from github-actions bot Aug 2, 2023
@crypto-org-chain crypto-org-chain deleted a comment from github-actions bot Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Simulation tests get triggered and started by /runsim.
Please check further progress here

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

/runsim simulation test has failed 😅
Please further check here

@mmsqe
Copy link
Collaborator Author

mmsqe commented Aug 2, 2023

/runsim

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Simulation tests get triggered and started by /runsim.
Please check further progress here

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

/runsim simulation test has succeeded 🎉
Please further check here

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the custom random account generations?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Aug 11, 2023

do we need the custom random account generations?

you mean this?

@mmsqe mmsqe enabled auto-merge August 21, 2023 05:56
@mmsqe mmsqe added this pull request to the merge queue Aug 21, 2023
Merged via the queue into crypto-org-chain:main with commit c1d977b Aug 21, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants