-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: not make use of sim utils from sdk #1117
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
===========================================
+ Coverage 22.92% 47.08% +24.16%
===========================================
Files 47 82 +35
Lines 3089 7312 +4223
===========================================
+ Hits 708 3443 +2735
- Misses 2311 3503 +1192
- Partials 70 366 +296
|
/runsim |
Simulation tests get triggered and started by |
❌ |
/runsim |
Simulation tests get triggered and started by |
✅ |
/runsim |
Simulation tests get triggered and started by |
❌ |
/runsim |
Simulation tests get triggered and started by |
✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the custom random account generations?
you mean this? |
c1d977b
For more info
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)