feature:Support_reconnect_backoff_interface #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
============================================
+ Coverage 37.07% 37.60% +0.52%
- Complexity 298 306 +8
============================================
Files 75 77 +2
Lines 2225 2234 +9
Branches 251 251
============================================
+ Hits 825 840 +15
+ Misses 1361 1356 -5
+ Partials 39 38 -1 ☔ View full report in Codecov by Sentry. |
| @@ -20,4 +22,5 @@ public interface ClientBuilder { | |||
| ClientBuilder okHttpClient(OkHttpClient okHttpClient); | |||
| ClientBuilder messageListener(MessageListener messageListener); | |||
| ClientBuilder callbackThreadPool(ThreadPoolExecutor callbackThreadPool); | |||
| ClientBuilder backoffStrategy(String backoffStrategy); | |||
There was a problem hiding this comment.
Suggested change
| ClientBuilder backoffStrategy(String backoffStrategy); | |
| ClientBuilder backoffStrategy(BackoffStrategy backoffStrategy); |
It is recommended to use the interface directly so that reflection is not needed.
| @@ -61,6 +62,7 @@ public Client buildClient(@Qualifier("callBackThreadPool") ThreadPoolExecutor ca | |||
| .okHttpClient(okHttpClient) | |||
| .messageListener(new MsgCallBackListener(msgLogger)) | |||
| .callbackThreadPool(callbackThreadPool) | |||
| .backoffStrategy(appConfiguration.getBackoffStrategy()) | |||
There was a problem hiding this comment.
For the cim-client, frequently modifying it is a low-frequency operation, and there is no need to store it in the configuration file.
It can be similar to messageListener.
cim-client-sdk/src/main/java/com/crossoverjie/cim/client/sdk/impl/ClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: crossoverJie <[email protected]>
…mpl/ClientBuilderImpl.java Co-authored-by: crossoverJie <[email protected]>
crossoverJie
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a TODO item in the list: The
ClientImpl.reconnectmethod requires a backoff interface. Consequently, a configuration has been added toClientConfigurationData. This configuration will support reading the fallback strategy fromapplication.yamland use reflection for instantiation inClientBuilder.