Cover UpdateSessionUUID with auth unit test
#7194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iously created sessions unusable
bbrks
force-pushed
the
unit_test_auth_user_updateSessionUUID
branch
from
bff621b
to
0b445de
Compare
torcolvin
approved these changes
Nov 15, 2024
| require.NoError(t, err) | ||
|
|
||
| _, err = auth.AuthenticateCookie(request, recorder) | ||
| require.EqualError(t, err, "401 Session no longer valid for user") |
There was a problem hiding this comment.
nit, take or leave:
I worry a bit about string matching and the formatting of this text and would have a slight preference for defining. base.HTTPErrorf(http.StatusUnauthorized, "Session no longer valid for user") as a constant and doing a errors.Is comparison. We do want to ultimately make sure that this comes back with 401 error and doing that means passing HTTPError up the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover
user.UpdateSessionUUIDwith a unit test to ensure it invalidates previously created sessions.The use of the Admin API endpoint was covered in
TestSessionAPIbut it doesn't acutally verify existing sessions are made unusable.Integration Tests