Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-4263 create single actor tests #7187

Merged
merged 9 commits into from
Nov 15, 2024
Merged

CBG-4263 create single actor tests #7187

merged 9 commits into from
Nov 15, 2024
+443 −147

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Nov 8, 2024 •
edited
Loading

CBG-4263 create the full single actor tests, though they are mostly skipped due to intermittent failures and lack of implementation of CBL. There are subsequent tickets for addressing them.

I added more optional data to DocVersion to allow seeing more information on assertions. This information isn't always going to be populated, but it is useful for printing out log message to see debugging.

Integration Tests

bbrks
bbrks requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I am unsure about the change to DocVersion
  • The linked Jira tickets in the t.Skip seem wrong, they refer to things other than the skip reason

db/crud.go Outdated Show resolved Hide resolved
rest/utilities_testing.go Outdated Show resolved Hide resolved
topologytest/hlv_test.go Outdated Show resolved Hide resolved
topologytest/hlv_test.go Outdated Show resolved Hide resolved
topologytest/hlv_test.go Outdated Show resolved Hide resolved
@torcolvin torcolvin assigned torcolvin and unassigned bbrks Nov 14, 2024
@torcolvin
CBG-4263 create single actor tests
5eade83
@torcolvin
wip
7d200f5
@torcolvin
Compare CV directly
00abd12
@torcolvin
skip rosmar tests, add debugging
1b69cbc
@torcolvin
fixes
959c4b8 
- update CBG ticket names
- remove all changes in rest package, create DocMetadata in topology
  test to include extended version information
- created log key VV for testing
@torcolvin torcolvin requested a review from bbrks November 15, 2024 13:37
@torcolvin torcolvin assigned bbrks and unassigned torcolvin Nov 15, 2024
@bbrks bbrks merged commit aa08f6c into release/anemone Nov 15, 2024
36 checks passed
@bbrks bbrks deleted the CBG-4263-single-actor branch November 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

@adamcfraser adamcfraser Awaiting requested review from adamcfraser

@gregns1 gregns1 Awaiting requested review from gregns1

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @bbrks