Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4213: add attachment migration api #7183

Merged
merged 5 commits into from
Nov 8, 2024
Merged

CBG-4213: add attachment migration api #7183

merged 5 commits into from
Nov 8, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Nov 6, 2024

CBG-4213

  • Addition of the api end point to trigger attachment migration and to get status of it
  • Move tests into separate package in rest
  • Api docs for this new endpoint

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copy link

github-actions bot commented Nov 6, 2024

Redocly previews

bbrks
bbrks previously approved these changes Nov 8, 2024
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nitpick but feel free to merge as-is

db/background_mgr_attachment_migration.go Outdated Show resolved Hide resolved
db/background_mgr_attachment_migration.go Outdated Show resolved Hide resolved
@bbrks bbrks assigned gregns1 and unassigned bbrks Nov 8, 2024
@bbrks bbrks merged commit 5043875 into release/anemone Nov 8, 2024
39 checks passed
@bbrks bbrks deleted the CBG-4213 branch November 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants