Merge audit logging feature branch into main
#6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add audit types and placeholder event * Add code and test to generate auditd compatible JSON module descriptor * Run addlicense * Rearrange for single-file of event definitiuons * Rename and clarify auditd type magic values
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
Ran into issues pretty quickly with import cycles due to audit code requiring utils in base (e.g. MultiError). This is just an inherent problem with SG's base package structure that we have to deal with. No easy way around this without larger refactoring and splitting of base, so just flatten audit into base.
* Initial implementation of Audit() - Replace placeholder with ReadDatabase * Validate the passed audit ID at Audit() invocation * Complete auth events descriptors * Run CI tests with cb_sg_devmode build flag * Run with devmode flag in integration tests * run race with devmode flag set * comment typo * Share common code across audit logger and file logger, rip out slog... * Rename `checkAuth` to `checkPublicAuth`, make audit events PublicUser specific (will have separate ones for Admin users), remove unused placeholder events.
…#6918) * Wire up config for audit logging. Per-database audit log settings can be read/written through /db/_config api * Show correct 'enabled' state for event in /db/_config/audit * Allow rutime setting of bootstrap logging.audit.enabled from root /_config like the other loggers
bbrks
force-pushed
the
feature/CBG-3822-audit-logging
branch
from
8c39b48
to
0ae687d
Compare
Redocly previews |
torcolvin
previously approved these changes
Jul 8, 2024
torcolvin
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge audit logging feature branch into
mainbase/auditpackage intobase#6905AuditEventstable to CSV for review/use by PM/Docs #6920Note to merger: DON'T SQUASH!
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2554/