feat: add custom querier to wasm image #7559
Merged
+187
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
requested review from
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
srdtrk and
bznein
as code owners
chatton
approved these changes
Nov 15, 2024
bznein
approved these changes
Nov 15, 2024
| return json.Marshal(aggregatedPublicKeys.Marshal()) | ||
| case customQuery.AggregateVerify != nil: | ||
| if len(customQuery.AggregateVerify.Message) != MessageSize { | ||
| return nil, fmt.Errorf("invalid message length, must be a 32bytes hash: %x", customQuery.AggregateVerify.Message) |
There was a problem hiding this comment.
[nit] I guess it doesn't hurt to add the obtained len to the error message. Also, you could use MessageSize instead of an hardcoded "32" in the message
There was a problem hiding this comment.
Yeah, added it now :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the custom querier needed for the union light client to the WASM simapp image.
This change also makes the usual amd64 image unusable on arm64 machines (Mac M1/2/etc.), so I've updated the build WASM image pipeline to build for amd64 and arm64 at the same time.
Unfortunately, the speed of that build has taken a significant hit due to the virtual nature of QEMU that is needed to build for arm64 on an amd64 machine. It can take up to around 25 minutes (https://github.com/cosmos/ibc-go/actions/runs/11817324167).
It is possible to improve this, but it would require a more complex pipeline that builds the images in a separate job with separate machines with separate tags (using the matrix strategy) and then downloads those images and pushes them together with the same tag. Or something very similar using Docker manifest - I haven't fully dived into the details yet (but it would be more complex for sure and take more time to set up). If this would be a big issue, I am open to doing that or finding other solutions.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.