Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ring with new ip address when instance is lost, rejoins, but heartbeat is disabled #6271

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

update ring with new ip address when instance is lost, rejoins, but heartbeat is disabled #6271

wants to merge 5 commits into from
+39 −7

Commits on Oct 16, 2024

  1. update ring with new ip address when instance is lost, rejoins, but h… 

    …eartbeat is disabled

Signed-off-by: Charlie Le <[email protected]>
    @CharlieTLe
    CharlieTLe committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e14b66d View commit details
    Browse the repository at this point in the history

  2. Fix lint error (ineffassign) 

    ```
pkg/ring/lifecycler_test.go:728:2: ineffectual assignment to l2 (ineffassign)
	l2 = startIngesterAndWaitActive("ing2", "0.0.0.0")
	^
```

Signed-off-by: Charlie Le <[email protected]>
    @CharlieTLe
    CharlieTLe committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    86d0e5a View commit details
    Browse the repository at this point in the history

  3. Update changelog 

    Signed-off-by: Charlie Le <[email protected]>
    @CharlieTLe
    CharlieTLe committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    90a4c67 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. simplify logic for handling address change 

    applying feedback from alanprot

Signed-off-by: Charlie Le <[email protected]>
    @CharlieTLe
    CharlieTLe committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f1f41ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-lifecycler-memberlist-rejoin-as-active… 

    …-new-ip-addr

Signed-off-by: Charlie Le <[email protected]>
    @CharlieTLe
    CharlieTLe authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    10ba017 View commit details
    Browse the repository at this point in the history