-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTX-5430: Coretex configuration centralization refactor. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart for node working).
# Conflicts: # coretex/cli/modules/node.py # coretex/cli/modules/ui.py # coretex/cli/modules/update.py
…the linter errors.
# Conflicts: # coretex/cli/commands/node.py # coretex/cli/modules/node.py saving changes.
…sync not being done first)....
# Conflicts: # coretex/cli/commands/node.py # coretex/cli/commands/project.py # coretex/cli/modules/config_defaults.py # coretex/cli/modules/node.py # coretex/cli/modules/project_utils.py
# Conflicts: # coretex/cli/modules/node.py
# Conflicts: # coretex/cli/commands/login.py # coretex/cli/commands/node.py # coretex/cli/commands/task.py # coretex/cli/main.py # coretex/cli/modules/config_defaults.py # coretex/cli/modules/node.py # coretex/cli/modules/project_utils.py # coretex/cli/modules/ui.py # coretex/cli/modules/update.py # coretex/cli/modules/user.py # coretex/configuration.py # coretex/utils/__init__.py # coretex/utils/process.py SOLVED CONFLICTS - > need to fix mypy right now and to test everything out.
dule1322
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these configuration changes backwards compatible? If not in _syncConfigWithEnv
function detect if the old config file is present and split it into two so that the users with already created configuration do not need to reconfigure anything.
…ubles, ive added isConfigured checks in isConfigValid. More improvements, migration fix.
# Conflicts: # coretex/cli/commands/task.py # coretex/folder_manager.py
# Conflicts: # coretex/cli/commands/node.py # coretex/cli/modules/node.py Fixed couple of found bugs.
dule1322
reviewed
Aug 8, 2024
dule1322
requested changes
Aug 8, 2024
dule1322
requested changes
Aug 9, 2024
# Conflicts: # coretex/cli/modules/node.py
# Conflicts: # coretex/utils/__init__.py
dule1322
reviewed
Aug 12, 2024
dule1322
reviewed
Aug 12, 2024
dule1322
reviewed
Aug 12, 2024
dule1322
reviewed
Aug 12, 2024
…red when they are supposed to and cause crash)
dule1322
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CTX-5430.