Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force domain name when redirecting #2024

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

david-a-wheeler
Copy link
Collaborator

If PUBLIC_HOSTNAME is set, just force its use when redirecting.

If PUBLIC_HOSTNAME is set, just *force* its use when redirecting.

Signed-off-by: David A. Wheeler <[email protected]>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (afb6910) 98.03% compared to head (090e6a7) 98.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2024   +/-   ##
=======================================
  Coverage   98.03%   98.04%           
=======================================
  Files          53       53           
  Lines        2091     2093    +2     
=======================================
+ Hits         2050     2052    +2     
  Misses         41       41           
Files Changed Coverage Δ
app/helpers/sessions_helper.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-a-wheeler david-a-wheeler merged commit 06e62c1 into main Aug 9, 2023
6 checks passed
@david-a-wheeler david-a-wheeler deleted the force_domain_name branch August 9, 2023 17:36
david-a-wheeler added a commit that referenced this pull request Aug 9, 2023
david-a-wheeler added a commit that referenced this pull request Aug 9, 2023
This reverts commit 06e62c1.

Signed-off-by: David A. Wheeler <[email protected]>
david-a-wheeler added a commit that referenced this pull request Aug 9, 2023
This reverts commit 06e62c1.

Signed-off-by: David A. Wheeler <[email protected]>
david-a-wheeler added a commit that referenced this pull request Aug 9, 2023
david-a-wheeler added a commit that referenced this pull request Aug 9, 2023
@david-a-wheeler david-a-wheeler mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant