Change how feed view is linked #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to determine why users are being redirected when they should *not* be redirected. When viewing the main page, the URLs are fine until "auto_discovery_link_tag" is called, and from then on the domain name is wrong. My hypothesis: this routine is incorrectly setting a global variable for the hostname, causing later calls to be wrong. So let's instead force the URL to a local reference, which is fine and eliminates the call entirely. I don't know if this will solve the problem, but this change is harmless, and its results can tell us if we're on the right track. Signed-off-by: David A. Wheeler <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 53 53
Lines 2091 2091
=======================================
Hits 2050 2050
Misses 41 41 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to determine why users are being redirected when they should not be redirected.
When viewing the main page, the URLs are fine until "auto_discovery_link_tag" is called, and from then on the domain name is wrong. My hypothesis: this routine is incorrectly setting a global variable for the hostname, causing later calls to be wrong.
So let's instead force the URL to a local reference, which is fine and eliminates the call entirely. I don't know if this will solve the problem, but this change is harmless, and its results can tell us if we're on the right track.