Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(renovate): fix configuring semantic commit type build #1853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sisp
Copy link
Member

@sisp sisp commented Nov 8, 2024

Just a minor Renovate config fix to make it use the semantic commit type build instead of chore/fix which included in config:recommended via :semanticPrefixFixDepsChoreOthers. It turns out that #1832 was incorrect because :semanticCommitType(build) is a preset for a setting, but :semanticPrefixFixDepsChoreOthers is a preset for package rules, so overriding those package rules requires a package rule (preset) – at least that's how I understand it. :semanticCommitTypeAll(build) is exactly this. See also renovatebot/renovate#8440.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (259f351) to head (6727a96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   97.72%   97.67%   -0.06%     
==========================================
  Files          49       49              
  Lines        5238     5238              
==========================================
- Hits         5119     5116       -3     
- Misses        119      122       +3     
Flag Coverage Δ
unittests 97.67% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisp sisp requested review from yajo and pawamoy November 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant