[REF] resource_work_time_from_contracts: add fixme comments

coopiteasy · Feb 8, 2024 · 7047976 · 7047976
1 parent 8d6eb34
commit 7047976
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/resource_work_time_from_contracts/models/resource_calendar_leaves.py b/resource_work_time_from_contracts/models/resource_calendar_leaves.py
@@ -13,6 +13,9 @@ class ResourceCalendarLeaves(models.Model):
     # leaves for all resources are defined in the same resource calendar,
     # which is needed to compute working hours while taking leaves into
     # account.
+    # fixme A readonly related field without an inverse method should not have a
+    #      default value, as it does not make sense.
+    #      cf odoo/odoo/fields.py:626
     calendar_id = fields.Many2one(
         "resource.calendar",
         related="resource_id.calendar_id",

diff --git a/resource_work_time_from_contracts/models/resource_mixin.py b/resource_work_time_from_contracts/models/resource_mixin.py
@@ -6,7 +6,7 @@
 
 from pytz import timezone, utc
 
-from odoo import fields, models
+from odoo import models
 from odoo.tools import float_utils
 
 from odoo.addons.resource.models.resource import ROUNDING_FACTOR
@@ -16,8 +16,6 @@ class ResourceMixin(models.AbstractModel):
 
     _inherit = "resource.mixin"
 
-    resource_calendar_id = fields.Many2one("resource.calendar")
-
     def list_work_time_per_day(
         self,
         from_datetime,

diff --git a/resource_work_time_from_contracts/models/resource_resource.py b/resource_work_time_from_contracts/models/resource_resource.py
@@ -9,6 +9,10 @@ class ResourceResource(models.Model):
     _inherit = "resource.resource"
 
     # force this field to be equal to the resource_calendar_id of the company.
+    # fixme A readonly related field without an inverse method should not have a
+    #      default value, as it does not make sense.
+    #      cf odoo/odoo/fields.py:626
+
     calendar_id = fields.Many2one(
         "resource.calendar",
         related="company_id.resource_calendar_id",