Check for various headers to simplify porting efforts #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
sedwards
force-pushed
the
macos_build
branch
3 times, most recently
from
87b36d8
to
71c83d7
Compare
Signed-off-by: Steven Edwards <[email protected]>
|
Sorry for the repeated force push, for some strange reason some of the rpm builds were failing even though none of the checks should have caused an issue. I finally got all of the checks to pass except there was a formatting issue that I didn't know about with clang-format so I ran it and it seems to have reformatted a few other things in the tree. Let me know if you want me to filter out those formatting changes and resubmit. Thanks! |
|
thanks for opening a PR! Won't the build fail when these headers are missing? Otherwise if they are not needed and the build succeeds, we can drop the include's. If I can ask, what platform are you targetting for the port? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the diff a little bit without hopefully adding too much to the Linux side