Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-configs: Add Ingress config #166

Merged

Conversation

surajssd
Copy link
Member

No description provided.

@surajssd
Copy link
Member Author

cc: @Xynnn007 @sameo @jialez0

@Xynnn007
Copy link
Member

@surajssd Thanks for the PR. Could you please rebase the code?

This commit adds configuration for exposing KBS on Ingress and also
instructions on how to set it up.

Signed-off-by: Suraj Deshmukh <[email protected]>
This fixes the formatting so when a user runs a kustomization command
the diff that they see is minimal.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
Copy link
Member Author

@Xynnn007 done

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @surajssd !

@Xynnn007 Xynnn007 merged commit b5476f3 into confidential-containers:main Nov 21, 2023
7 checks passed
@surajssd surajssd deleted the k8s-deploy-ingress-install branch November 22, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants