Skip to content

Commit

Permalink
Dockerfile: fix capitalization
Browse files Browse the repository at this point in the history
Docker prefers that statements using FROM and AS have those two words in the
same case and will even warn you about it if you don't.

See https://docs.docker.com/reference/build-checks/from-as-casing/

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
  • Loading branch information
fitzthum authored and Xynnn007 committed Nov 5, 2024
1 parent aec9296 commit 043ad0b
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions attestation-service/docker/as-grpc/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0

FROM rust:latest as builder
FROM rust:latest AS builder
ARG ARCH=x86_64

WORKDIR /usr/src/attestation-service
Expand Down Expand Up @@ -44,4 +44,4 @@ VOLUME /opt/confidential-containers/attestation-service

CMD ["grpc-as", "--socket", "0.0.0.0:50004"]

EXPOSE 50004
EXPOSE 50004
4 changes: 2 additions & 2 deletions attestation-service/docker/as-restful/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0

FROM rust:latest as builder
FROM rust:latest AS builder
ARG ARCH=x86_64

WORKDIR /usr/src/attestation-service
Expand Down Expand Up @@ -45,4 +45,4 @@ VOLUME /opt/confidential-containers/attestation-service

CMD ["restful-as", "--socket", "0.0.0.0:8080", "--config-file", "/etc/config.json"]

EXPOSE 8080
EXPOSE 8080
2 changes: 1 addition & 1 deletion kbs/docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust:slim as builder
FROM rust:slim AS builder
ARG ARCH=x86_64
ARG ALIYUN=false

Expand Down
2 changes: 1 addition & 1 deletion kbs/docker/coco-as-grpc/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust:latest as builder
FROM rust:latest AS builder
ARG ARCH=x86_64
ARG ALIYUN=false

Expand Down
2 changes: 1 addition & 1 deletion kbs/docker/intel-trust-authority/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust:latest as builder
FROM rust:latest AS builder
ARG ALIYUN=false

WORKDIR /usr/src/kbs
Expand Down
2 changes: 1 addition & 1 deletion kbs/docker/rhel-ubi/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Use CentOS Stream to build.
FROM quay.io/centos/centos:stream9 as builder
FROM quay.io/centos/centos:stream9 AS builder

# Install build dependencies from CentOS repos.
RUN dnf -y --setopt=install_weak_deps=0 --enablerepo=crb install \
Expand Down
4 changes: 2 additions & 2 deletions rvps/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the Apache License, Version 2.0, see LICENSE for details.
# SPDX-License-Identifier: Apache-2.0

FROM rust:latest as builder
FROM rust:latest AS builder

WORKDIR /usr/src/rvps

Expand All @@ -22,4 +22,4 @@ CMD ["rvps"]

VOLUME /opt/confidential-containers/attestation-service/reference_values/

EXPOSE 50003
EXPOSE 50003

0 comments on commit 043ad0b

Please sign in to comment.