pre-install: Fix service name for cri-o runtime #424
Conversation
There was a problem hiding this comment.
My only concern was that in some systems, cri-o service would be called 'cri-o' instead of 'crio'. Because I remember testing crio + ubuntu before. But I just tested with ubuntu2204, and both will work, so this LGTM, thanks @ldoktor
| service_name="${container_engine}" | ||
| fi | ||
| echo "Restarting ${service_name}" | ||
| host_systemctl restart "${service_name}" |
There was a problem hiding this comment.
I'd rather solve this here: https://github.com/confidential-containers/operator/pull/424/files#diff-1d64c80e2d9aea0884eef362ad623406c0edb4de1295dd31579a9270bc428c3eR44
This is what we do on the Kata Containers side: https://github.com/kata-containers/kata-containers/blob/ef5a5ea26e893b1f7fa20bd82eca402b11f08b21/tools/packaging/kata-deploy/scripts/kata-deploy.sh#L609-L610
the cri-o runtime naming is inconsistent and for service uses "crio.service" name (without the "-"). To be consistent with kata-containers override the container_engine variable to "crio" and update all places where it's being used. Related to: confidential-containers#418 Signed-off-by: Lukáš Doktor <[email protected]>
|
@fidencio makes sense to me (although personally I'd move it even directly to |
the cri-o runtime uses "crio.service" service name (tested on OCP 4.14)
Related to: #418