ESM support #30
Open
ESM support #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converts CommonJS module.exports to ESM export using a Rollup plugin - Adds an ESM import to the example in README.md - Adds the change in HISTORY.md - Adds "exports" key in package.json to detect proper export automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added ESM support to this package. Things done in this commit:
- Converts CommonJS module.exports to ESM export using a Rollup plugin
- Adds an ESM import to the example in README.md
- Adds the change in HISTORY.md
- Adds "exports" key in package.json to detect proper export automatically
I don't know Travis CI though, that should probably be updated too so that index.mjs will not be ignored when installing the package using NPM. Thank you.