Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ach card to use game IDs (which are in save) #106

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

Esummins
Copy link
Collaborator

@Esummins Esummins commented May 8, 2024

Apparently the game IDs for achievements weren't in the json, this update lets the card find the right ID and mark them as complete.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stardew ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 5:44pm

@jacc
Copy link
Collaborator

jacc commented May 10, 2024

From Vercel:

./src/pages/farmer.tsx:315:17
--
23:13:29.991 | Type error: Property 'gameID' is missing in type '{ id: number; name: string; description: string; iconURL: string; }' but required in type 'Achievement'.

@Esummins Esummins merged commit 8b25d97 into main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants