Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont check for socketcan when not available #34039

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

pbassut
Copy link
Contributor

@pbassut pbassut commented Nov 16, 2024

Description

Not a huge value PR I know but helps me get started.

Closes #34038

Verification

Run:

./tools/cabana/cabana

@github-actions github-actions bot added the tools label Nov 16, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh adeebshihadeh merged commit 22d19f2 into commaai:master Nov 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socketcan warning when opening cabana on MacOS
2 participants