Refactor get_port to use FNV-1a hash for consistency across platforms #634
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve commaai/openpilot#34031 :
This pr fixes the issue where the
get_port
function returns different port values on macOS and Linux due to platform-specific behavior ofstd::hash
. The mismatch in port values causes connection failures in ZMQ. The solution replacesstd::hash
with a custom FNV-1a hash function to ensure consistent port values across platforms, and reducing the risk of collisions.