Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Next.js #45

Merged
merged 15 commits into from
Jun 1, 2024
Merged

Remove Next.js #45

merged 15 commits into from
Jun 1, 2024

Conversation

incognitojam
Copy link
Contributor

@incognitojam incognitojam commented Jun 1, 2024

I'm not sure what I had in mind when I created the app, but we don't need 95% of the features Next.js provides.

  • remove Next.js
  • use vite to build
  • import fonts using fontsource (instead of next/font)
  • setup eslint (previously using next config)
  • replace next-plausible with script import in index.html (and removed event tracking in fastboot.js)

This might be an easier first step than switching to a different framework - the react stuff still works!

@adeebshihadeh
Copy link
Collaborator

So moving off React here is mostly a testing ground for connect, but I agree this is a good start!

@wgenh
Copy link

wgenh commented Jun 1, 2024

Should PR #43 be closed?

@adeebshihadeh adeebshihadeh merged commit 0a66ca6 into commaai:master Jun 1, 2024
1 check passed
@incognitojam incognitojam deleted the vite-react branch June 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants