Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add react-dates dependency #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add react-dates dependency #56

wants to merge 3 commits into from

Conversation

ionlizarazu
Copy link
Member

No description provided.

@pnicolli
Copy link
Member

I am ok with adding the dependency. I would add the same version we use in Volto though, for consistency. Or at least anything that won't get us a double react-dates dep in node_modules. Also, while we're here, maybe it's worth adding rc-time-picker if you have a few extra minutes to spare.

avoinea
avoinea requested changes Jun 6, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ionlizarazu
Update package.json
6a54b70 
add missing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avoinea avoinea avoinea approved these changes

@tiberiuichim tiberiuichim tiberiuichim approved these changes

@pnicolli pnicolli Awaiting requested review from pnicolli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ionlizarazu @pnicolli @tiberiuichim @avoinea @erral