Skip to content

Commit

Permalink
Merge branch 'main' into fedora38
Browse files Browse the repository at this point in the history
  • Loading branch information
octo committed Dec 21, 2023
2 parents 4ca0af3 + bac09b5 commit 3fe4dae
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 24 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/daily-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ jobs:

matrix:
branch:
- sid_amd64
- debian_unstable
- fedora38_x86_64
- fedora_rawhide_x86_64

env:
SLUG: "collectd/ci:${{ matrix.branch }}"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
- name: Build container
Expand All @@ -32,7 +32,7 @@ jobs:
- run: docker inspect "${SLUG}"
- run: docker history "${SLUG}"
- name: Log into the container registry
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- run: docker history "${SLUG:?}"
- run: docker images
- name: Log into the container registry
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/weekly-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
SLUG: "collectd/ci:${{ matrix.branch }}"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
- name: Build container
Expand All @@ -48,7 +48,7 @@ jobs:
- run: docker inspect "${SLUG}"
- run: docker history "${SLUG}"
- name: Log into the container registry
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down
30 changes: 15 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,29 @@ Helper images for building collectd
Here is a collection of manifests used to build the Docker images hosted at:
<https://cloud.docker.com/u/collectd/repository/docker/collectd/ci/tags>

There is one branch per distribution/architecture pair which collectd is tested
against. Common bits are stored in the master branch, and merged into the
distro branches when needed.
There is one branch per distribution/version against which collectd is tested.
Common bits, most notably GitHub Actions, are stored in the main branch, and
merged into the distro branches when needed.

Each Dockerfile contains a list of package names (mostly support libraries) to
install, and a list of plugins collectd *master* is expected to build based on
install, and a list of plugins collectd *main* is expected to build based on
them. We want to stick to the official repositories, and only install packages
found there, to ensure collectd releases integrate smoothly in these
distributions.

Travis-CI takes care of building these images and pushing them to
cloud.docker.com. NB: Debian/sid and Fedora/rawhide built are triggered once
per day (as these distributions change constantly). You'll find the build logs
there: <https://travis-ci.org/collectd/ci-docker/builds>
GitHub Actions take care of building these images and pushing them to
`cloud.docker.com`.

NOTE: Debian unstable ("Sid") and Fedora unstable ("Rawhide") are rebuilt daily
(as these distributions change frequently).

The goal is to have the resulting images fit in the collectd project's CI, but
they are free to use for any other case. Only patches related to the CI will be
considered, though.
they are free to use for any other case.

Here's an example of how you could build collectd in an Ubuntu/Xenial
environment:
```
Here's an example of how you can build collectd on Debian unstable:

```shell
git clone https://github.com/collectd/collectd
docker run -it --rm -v $PWD/collectd:/collectd -w /collectd collectd/ci:xenial_amd64
./build.sh && ./configure && make && make check
docker run -it --rm -v $PWD/collectd:/collectd -w /collectd collectd/ci:debian_unstable
./build.sh && ./configure && make all check
```
13 changes: 10 additions & 3 deletions checks/check-built-plugins.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,16 @@
set -e

declare -A want
for p in ${SUPPORTED_PLUGIN_LIST}; do
want["${p}"]=1
done
if [[ $# -ge 1 ]]; then
for p in $(egrep -v '^ *($|#)' "${1}"); do
want["${p}"]=1
done
else
echo "No plugins on the command line; using SUPPORTED_PLUGIN_LIST instead."
for p in ${SUPPORTED_PLUGIN_LIST}; do
want["${p}"]=1
done
fi

declare -A got
for f in .libs/*.so; do
Expand Down

0 comments on commit 3fe4dae

Please sign in to comment.