-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double quotation from parameter #122
base: main
Are you sure you want to change the base?
Conversation
@@ -483,7 +483,7 @@ | |||
"'}'", | |||
[ | |||
[ | |||
"WordDoubleQuoted", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this one is correct because now we have a WordSingleQuoted
inside another WordSingleQuoted
. I think that, similarly to the other cases, we should just remove the layer of WordDoubleQuoted
altogether. Not entirely sure though.
The tests suite in CI is currently unreadable. This should be fixed by #169 so maybe we should wait for that, rebase this on top of |
Yes, let's do that. |
Right now, an extra set of double quotes surrounds every parameter. This pull request fixes that.
Test plan: