Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: correct description of top_k parameter in function docstring #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randyshee
Copy link

Thank you so much for sharing the code for DESP, and congratulations on the acceptance to NeurIPS 2024!

While exploring the package, I noticed that the top_k parameter was described as "The number of top routes to keep in the final solution" in desp/DESP.py, but it seems to refer to the number of top building blocks to consider for each bimolecular reaction. To clarify, I’ve updated the docstring to reflect this.

Additionally, I believe an enhancement that allows for returning more than just the top 1 route in the final solution (as the original description suggests) could be a valuable feature to consider for future updates.

Thanks again for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant