bridge: Fix crash on invalid cockpit.conf #21270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
previously approved these changes
Nov 14, 2024
martinpitt
force-pushed
the
bridge-conf-crash
branch
from
c98e35c
to
7aae2ae
Compare
|
Ah, some error message noise, and the test_branding rename needs a pixel rename. Fixed. |
All other test cases use testCamelCase. Do the corresponding rename in the pixel refs.
If there is a syntax error in cockpit.conf, the bridge previously crashed with e.g. a `configparser.MissingSectionHeaderError`. Intercept that, log a warning instead, and ignore the config file instead. https://bugzilla.redhat.com/show_bug.cgi?id=2324979
martinpitt
force-pushed
the
bridge-conf-crash
branch
from
7aae2ae
to
f86615a
Compare
|
Ah, Python 3.13 gives better error messages. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a syntax error in cockpit.conf, the bridge previously
crashed with e.g. a
configparser.MissingSectionHeaderError.Intercept that, log a warning instead, and ignore the config file
instead.
https://bugzilla.redhat.com/show_bug.cgi?id=2324979